I18n: Make preview popup loader strings translateable #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Nov 2, 2017
| @@ -76,8 +76,8 @@ export class PreviewButton extends Component { | |||
|
|
|||
| const markup = ` | |||
| <div> | |||
| <p>Please wait…</p> | |||
| <p>Generating preview.</p> | |||
| <p>${ __( 'Please wait…' ) }</p> | |||
There was a problem hiding this comment.
Unlike with React, we don't get string escaping for free here, so there is a potential risk with inserting this into raw markup.
https://codex.wordpress.org/I18n_for_WordPress_Developers#HTML
We may need to consider patterns for sanitization.
There was a problem hiding this comment.
We could also generate this with wp.element.renderToStaticMarkup as an element.
Or just Lodash _.escape
aduth
requested changes
Mar 6, 2018
| @@ -76,8 +76,8 @@ export class PreviewButton extends Component { | |||
|
|
|||
| const markup = ` | |||
| <div> | |||
| <p>Please wait…</p> | |||
| <p>Generating preview.</p> | |||
| <p>${ __( 'Please wait…' ) }</p> | |||
There was a problem hiding this comment.
We could also generate this with wp.element.renderToStaticMarkup as an element.
Or just Lodash _.escape
aduth
added
[Status] Stale
|
Looks like this PR has got stale, so closing it for now. If you can revisit it feel free to re-open this PR or open a new PR. |
|
Closed this but filed #7725 to track this issue. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds translate functions to the text strings in the preview popup loader.