Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add mailto: to email addresses when linking #9774

Closed
iandunn opened this issue Sep 11, 2018 · 3 comments · Fixed by #14857
Closed

Automatically add mailto: to email addresses when linking #9774

iandunn opened this issue Sep 11, 2018 · 3 comments · Fixed by #14857
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Format library /packages/format-library [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@iandunn
Copy link
Member

iandunn commented Sep 11, 2018

The Classic editor automatically prepends mailto: to email addresses if you highlight them and click on the link icon. I think users will expect that Gutenberg does this as well (example).
@iandunn iandunn added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Sep 11, 2018
@mtias mtias added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Oct 8, 2018
@ellatrix ellatrix added [Package] Format library /packages/format-library and removed [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Jan 24, 2019
@paaljoachim
Copy link
Contributor

@iseulde
Ella is this an issue you can take care of? Thanks.

@ellatrix ellatrix added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 30, 2019
@ellatrix
Copy link
Member

Sounds like a fairly simple fix. Added the Good First Issue label.

@luisherranz
Copy link
Member

luisherranz commented Apr 7, 2019 •
edited
Loading

I've made a PR: #14857

The link component is using @wordpress/url to do the URL check but I haven't found anything similar in @wordpress so I have added a regexp. If you want I can do a PR to include an email validator in @wordpress/url or the appropriate library.

@luisherranz luisherranz mentioned this issue Apr 7, 2019
Merged
5 tasks
@Zodiac1978 Zodiac1978 mentioned this issue Jul 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Format library /packages/format-library [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically add mailto: to email addresses when linking luisherranz/gutenberg
5 participants
@iandunn @mtias @luisherranz @ellatrix @paaljoachim