Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add mailto: to email addresses when linking #14857

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Automatically add mailto: to email addresses when linking #14857

merged 4 commits into from
Apr 9, 2019

Conversation

luisherranz
Copy link
Member

@luisherranz luisherranz commented Apr 7, 2019 •
edited
Loading

Description

The link field is automatically populated when the selected text is an email.

How has this been tested?

I've done manual tests of the editor and added unit tests for the isEmail validator.

Screenshots

ezgif com-video-to-gif

Types of changes

Checklist:

  • My code is tested (only unit tests for isEmail).
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Fixes #9774

@luisherranz luisherranz mentioned this pull request Apr 7, 2019
Closed
@mtias mtias added [Package] Url /packages/url [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Apr 7, 2019
youknowriad
youknowriad approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@youknowriad youknowriad merged commit 8eb5a6e into WordPress:master Apr 9, 2019
@mtias
Copy link
Member

mtias commented Apr 9, 2019

Thanks @luisherranz :)

@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
This was referenced Apr 15, 2019
Merged
Closed
Closed
Merged
@aduth aduth mentioned this pull request Apr 13, 2020
Closed
@jeryj jeryj mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias mtias left review comments

@youknowriad youknowriad youknowriad approved these changes

@aduth aduth Awaiting requested review from aduth

@ellatrix ellatrix Awaiting requested review from ellatrix

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@gziolo gziolo Awaiting requested review from gziolo

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Package] Url /packages/url
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

Automatically add mailto: to email addresses when linking
3 participants
@luisherranz @mtias @youknowriad