Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Always use the latest version of NVM #10586

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

aaronjorbin
Copy link
Member

Currently the local dev enviornment pins to a 10 month old version of NVM, which means that when we say we are "updating NVM", it can easily be downgrading NVM. This adds a one line to get the latest version and use that.

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Currently the local dev enviornment pins to a 10 month old version of NVM, which means that when we say we are "updating NVM", it can easily be downgrading NVM. This adds a one line to get the latest version and use that.
@gziolo gziolo requested a review from a team October 14, 2018 08:51
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't write or review this code so I'm not sure why we are using that version of NVM. A consistent environment is nice but in the case of NVM I'm fine with just using the latest version.

This gets 👍 from me, but @pento wrote that line and could perhaps explain the reasoning behind it? 🤷‍♂️

Copy link
Member

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally wrote it as a "here's a version that works" thing, but realistically, I don't expect our basic usage of NVM to cause back compat problems.

@pento pento added this to the 4.1 - UI freeze milestone Oct 16, 2018
@pento pento merged commit 6e9c18f into master Oct 16, 2018
@pento pento deleted the fix/always-use-latest-nvm branch October 16, 2018 03:03
@mtias mtias added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 18, 2018
@shivapoudel
Copy link
Contributor

@pento In windows environment, rev command won't exist. Can this utilize grep command?

@pento
Copy link
Member

pento commented Aug 16, 2019

@shivapoudel: This script will likely become obsolete when #17004 is merged, so I don't think it'll be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants