Writing Flow: Unset typing flag if Escape pressed #10906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #10699
This pull request seeks to resolve an issue where the contextual block toolbar is not accessible by keyboard when typing, except by artificially creating a selection for the mere purpose of deactivating the "is typing" application state flag. It does so by canceling the typing mode when the user presses Escape.
Implementation notes:
There are still some undesirable behaviors, of which this is not intended to cover, though I will create issues for:
Testing instructions:
Verify that, after typing in a paragraph block, pressing Escape causes the toolbar to be shown.