Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Fixing vertical alignment of the image #11025

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Media & Text: Fixing vertical alignment of the image #11025

merged 2 commits into from
Oct 25, 2018

Conversation

webmandesign
Copy link
Contributor

Fixes #11024

Potentially could be even fixed with vertical-align: top;

@Soean Soean changed the title Fixing vertical alignment of the image Media & Text: Fixing vertical alignment of the image Oct 24, 2018
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot @webmandesign for looking into this problem and providing a simple fix, it works great on my tests 👍
Can we apply the same fix to the editor styles in this PR?
In https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/media-text/editor.scss#L46
We can replace margin-bottom: -8px; with vertical-align: middle;.

@webmandesign
Copy link
Contributor Author

@jorgefilipecosta Just fixed the editor styles too. Thanks for noticing :)

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for applying this changes!

@jorgefilipecosta jorgefilipecosta merged commit c5227f3 into WordPress:master Oct 25, 2018
@jorgefilipecosta jorgefilipecosta added this to the 4.2 milestone Oct 25, 2018
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
daniloercoli added a commit that referenced this pull request Oct 26, 2018
…rnmobile/merge-blocks-on-backspace

* 'master' of https://github.com/WordPress/gutenberg:
  Do not add isDirty prop to DOM (#11093)
  Format API (#10209)
  Remove 4.2 deprecated features (#10952)
  Update `@wordpress/hooks` README to include namespace mention (#11061)
  Feature: save lock control via actions (#10649)
  Fix usage of `preg_quote()` (#10998)
  Update plugin version to 4.1.1 (#11078)
  Improve preloading request code (#11007)
  Fix dynamic blocks not rendering in the frontend (#11050)
  Media & Text: Fixing vertical alignment of the image (#11025)
  Date: Mark getSettings as experimental (#10636)
  Improve handling of centered 1-col galleries with small images (#11040)
  Use better help text for ALT text input; fixes #8391. (#11052)

# Conflicts:
#	packages/editor/src/components/rich-text/index.native.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block: Media & Text image vertical alignment is wrong
2 participants