Slot/Fill pattern with Toolbar #199 #11115
Conversation
marecar3
changed the title
|
What's blocking it from merging? It looks good 👍 |
|
Okey, I see your comment: wordpress-mobile/gutenberg-mobile#199 (comment). |
gziolo
added
the
Mobile App - i.e. Android or iOS
Set style explicitly to code
marecar3
changed the title
| @@ -83,7 +82,9 @@ class ParagraphEdit extends Component { | |||
| tagName="p" | |||
| value={ content } | |||
| style={ { | |||
| ...style, | |||
| // We don't want to pass style here from upper leyers, because it's corrupted | |||
There was a problem hiding this comment.
It would be good if we can re-use the work we did for the Inserter's SVGs case where we take the concatenated string passed in the props and convert it to proper style format. Can we make a utility function out of that work and use it here? (Same for the code block above, or elsewhere)
There was a problem hiding this comment.
Is this class name ever converted to style properly with the Babel plugin that's used in the project?
There was a problem hiding this comment.
Hey @hypest @gziolo, I saw the solution for converting style string to style object, but when I look at the input (style string) and output (style object) it doesn't make sense for this case.
This is what I get as a style"custom-class-1 custom-class-2 has-background has-drop-cap has-large-font-size has-vivid-red-background-color"' I think that I don't want that to be converted into style, as I didn't pass it. What do you think about it? I am open for suggestions.
Read minHeight from file
…or theme.ios.scss file
…m/WordPress/gutenberg into rnmobile/native-toolbar-component
🎉
…rnmobile/fix-merge-content-not-refreshed-UI * 'master' of https://github.com/WordPress/gutenberg: Fix the isBeingScheduled Selector. (#11572) Slot/Fill pattern with Toolbar #199 (#11115) Add mechanism to avoid forced child selection on blocks with templates. (#10696) Allow a block to disable being converted into a reusable block; Fix: Column block (#11550)
Description
This PR exposes Slot/Fill pattern for gutenberg-mobile. It is tested with gutenberg-mobile PR
Screenshots
To test: