Fix: Cover image tooltips for alignment are duplicated #11263
Conversation
jorgefilipecosta
added
[Type] Enhancement
|
Shouldn't this change be implemented for all text alignment controls? |
| @@ -35,19 +35,19 @@ const ALIGNMENT_CONTROLS = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| export function AlignmentToolbar( { isCollapsed, value, onChange } ) { | |||
| export function AlignmentToolbar( { isCollapsed, value, onChange, alignmentControls = ALIGNMENT_CONTROLS } ) { | |||
There was a problem hiding this comment.
Should we we add a unit test for this new prop? I see that the component already has some unit tests.
Also, a nit: Renaming the constant to DEFAULT_ALIGNMENT_CONTROLS would better convey what it now does.
There was a problem hiding this comment.
Was thinking we should document this new prop as well. Sadly, it looks like AlignmentToolbar is missing a README...
| }, | ||
| { | ||
| icon: 'editor-alignright', | ||
| title: __( 'Text align right' ), |
There was a problem hiding this comment.
These should read Align text left, Align text center, and Align text right.
I think Cover is the only block that has both block alignment and text alignment in the same toolbar. |
jorgefilipecosta
force-pushed
the
fix/Cover-image-tooltips-for-alignment-are-duplicated
branch
from
a5d642f
to
bec8ba6
Compare
|
Agreed with @ZebulanStanphill I also think it'd be better if it's implemented globally for consistency. Even if Cover Image is the only one having both, it feels like the tooltip shouldn't be different across blocks. Let's get some designer eyes here for ideas @alexislloyd @jasmussen @karmatosed |
|
I like the idea of both distinct tooltips (because their behaviors differ), and consistency across all text alignments. I have a preference for "Align text left" over "Text align left", though. |
jorgefilipecosta
force-pushed
the
fix/Cover-image-tooltips-for-alignment-are-duplicated
branch
from
bec8ba6
to
ee511b2
Compare
jorgefilipecosta
force-pushed
the
fix/Cover-image-tooltips-for-alignment-are-duplicated
branch
from
ee511b2
to
1a98606
Compare
| align: 'right', | ||
| }, | ||
| ]; | ||
|
|
||
| export function AlignmentToolbar( { isCollapsed, value, onChange } ) { | ||
| export function AlignmentToolbar( { isCollapsed, value, onChange, alignmentControls = DEFAULT_ALIGNMENT_CONTROLS } ) { |
There was a problem hiding this comment.
This change is not needed anymore right? can we remove it?
There was a problem hiding this comment.
It is not needed but I liked this change, it allows a block for example to only offer right or left alignment, or to change labels in a specific case, e.g: instead of text naming the actual field "Author name align left" that may be very useful for a11y.
jorgefilipecosta
deleted the
fix/Cover-image-tooltips-for-alignment-are-duplicated
branch
Description
Fixes: #6013
The same tooltip as used for Block Alignment and text Alignment.
This PR makes sure we use different tooltips for the text alignment buttons.
https://user-images.githubusercontent.com/253067/38373204-92586b58-38e8-11e8-8ec2-09e73368cacb.png
How has this been tested?
I added a cover block and I checked that the tooltips for text alignment are in the format "Text align left/center/right" and block alignment tooltips are in the format "Text left/center/right"
Screenshots
Before:
After:
