Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11474 #11475

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Fixes #11474 #11475

merged 1 commit into from
Nov 5, 2018

Conversation

timelsass
Copy link
Contributor

Description

Fixes #11474 by adding text-decoration: none; to the button style's :focus and :hover states.

How has this been tested?

Tested using a blank _s theme with the style.css enqueued in the editor with a:hover, a:focus { text-decoration: underline; } added.

Types of changes

Bug fix: removes underline style that could be inherited by a theme's style.css

Checklist:

  • [ x ] My code is tested.
  • [ x ] My code follows the WordPress code style.
  • [ x ] My code follows the accessibility standards.
  • [ x ] My code has proper inline documentation.

@ajitbohra ajitbohra added the [Type] Enhancement A suggestion for improvement. label Nov 5, 2018
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Ship it!

@jasmussen jasmussen added this to the 4.3 milestone Nov 5, 2018
@jasmussen jasmussen merged commit 3a59842 into WordPress:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default link styles conflict with editor button component link
3 participants