Removed unnecessary className attribute. Fixes #11664 #11831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR includes commits from other PR's I guess only relevant change here is https://github.com/WordPress/gutenberg/pull/11831/files#diff-8dbba509e48db673fbe1ad06dd51d289 |
|
I merged master in an attempt to solve the failing Travis builds |
jorgefilipecosta
force-pushed
the
fix/11664
branch
from
e0f4b16
to
6dbcf66
Compare
jorgefilipecosta
approved these changes
Jan 30, 2019
daniloercoli
added a commit
that referenced
this pull request
Jan 30, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (36 commits) Fixes plural messages POT generation. (#13577) Typo fix (#13595) REST API: Remove oEmbed proxy HTML filtering (#13575) Removed unnecessary className attribute. Fixes #11664 (#11831) Add changelog for RSS block (#13588) Components: Set type=button for TabPanel button elements. (#11944) Update util.js (#13582) Docs: Add accessbility specific page (#13169) Rnmobile/media methods refactor (#13554) chore(release): publish chore(release): publish Plugin: Deprecate gutenberg_get_script_polyfill (#13536) Block API: Parse entity only when valid character reference (#13512) RichText: List: fix indentation (#13563) Plugin: Deprecate window._wpLoadGutenbergEditor (#13547) Plugin: Avoid setting generic "Edit Post" title on load (#13552) Plugin: Populate demo content by default content filters (#13553) RichText: List: Fix getParentIndex (#13562) RichText: List: Fix outdent with children (#13559) Scripts: Remove npm run build from test-e2e default run (#13420) ...
|
Thanks for the merge! @jorgefilipecosta |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
## Description
Added a check for empty string to the `onChange` handler of the "Additional CSS Class field".
If the string is empty the `setAttributes` is called with `{ className: undefined }`
This will resolve #11664
## How has this been tested?
Created a new post and added a heading block.
In the Advanced menu, added a class and switched to the Code Editor
Tested on local WP running on Windows with Chrome 70.0.3538.102
## Types of changes
Bug fix (non-breaking change which fixes an issue)
## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
## Description
Added a check for empty string to the `onChange` handler of the "Additional CSS Class field".
If the string is empty the `setAttributes` is called with `{ className: undefined }`
This will resolve #11664
## How has this been tested?
Created a new post and added a heading block.
In the Advanced menu, added a class and switched to the Code Editor
Tested on local WP running on Windows with Chrome 70.0.3538.102
## Types of changes
Bug fix (non-breaking change which fixes an issue)
## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check for empty string to the
onChangehandler of the "Additional CSS Class field".If the string is empty the
setAttributesis called with{ className: undefined }This will resolve #11664
How has this been tested?
Created a new post and added a heading block.
In the Advanced menu, added a class and switched to the Code Editor
Tested on local WP running on Windows with Chrome 70.0.3538.102
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: