Perform a complete draft save on preview #12097
Conversation
# Conflicts: # packages/editor/src/components/post-preview-button/index.js
| * | ||
| * @return {string?} Updated state. | ||
| */ | ||
| export function previewLink( state = null, action ) { |
There was a problem hiding this comment.
Preview link is tracked separately as it's not directly related to autodrafts anymore.
gziolo
added
[Type] Bug
| export function getEditedPostPreviewLink( state ) { | ||
| const featuredImageId = getEditedPostAttribute( state, 'featured_media' ); | ||
| const previewLink = state.previewLink; | ||
| if ( previewLink && featuredImageId ) { |
There was a problem hiding this comment.
we should add also a unit test, can be a follow-up PR
There is one e2e test to fix and we should be good to go. In my testing, everything works as expected. |
| previewLink = addQueryArgs( previewLink, { _thumbnail_id: featuredImageId } ); | ||
| } | ||
|
|
||
| const previewLink = getEditedPostPreviewLink(); |
There was a problem hiding this comment.
previewLink can be inlined again.
|
|
||
| await editorPage.bringToFront(); | ||
| await waitForPreviewNavigation( previewPage ); | ||
| expect( previewPage.url() ).toBe( expectedPreviewURL ); |
There was a problem hiding this comment.
I removed this part because in my testing even if the url is a preview url and not the final url, it works as intended.
There was a problem hiding this comment.
It works this way in classic, so maybe we should keep it with this param.
There was a problem hiding this comment.
I don't remember why this part is here, @aduth should confirm whether we can remove it. I remember that this test was very fragile in the past.
There was a problem hiding this comment.
I think the idea was that if there is nothing to save and we have a known preview URL, we don't save, we go straight to the preview URL.
I don't know that it's necessarily breaking to let the save go through, however.
There was a problem hiding this comment.
yes, that was my thinking, if the save request returns a URL, just use it whether there are dirtiness or not shouldn't affect it. and also restoring the old behavior was adding a bit of unnecessary complexity.
| isSaveable: isEditedPostSaveable(), | ||
| isAutosaveable: forceIsAutosaveable || isEditedPostAutosaveable(), | ||
| isViewable: get( postType, [ 'viewable' ], false ), | ||
| isDraft: [ 'draft', 'auto-draft' ].indexOf( getEditedPostAttribute( 'status' ) ) !== -1, |
There was a problem hiding this comment.
Seems like a possible candidate for a selector.
There was a problem hiding this comment.
We do have a bunch of isEditedPostSomething, this could be isEditedPostDraft but again is auto-draft a draft.
But overall agreed, for now it's specific to this component so maybe fine to leave it as is?
closes #12047
fixes #9151
This is a follow-up to #12037 (comment) and it builds on top of some changes in #11409
This PR changes the behavior of the preview button. It now performs a full draft save (on non published posts) before previewing the post. This matches Core behavior. (classic editor)
Testing instructions