Link Format: Label with selected text, not full text

[ellatrix]

Description

See #11063 (comment). Link are being labeled with the full field's content, not just the selected text.

• Only labels with selected text.
• Removes trimming since the text cannot be empty.

How has this been tested?

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[ellatrix]

@ryanwelcher @afercia I don't understand why there's only a label being added with the selected text if the link opens in a new tab. Shouldn't every link contain a label then? If not, maybe links that open in a new tab shouldn't include the selected text as the label. This seems inconsistent to me.

[afercia]

aria-label overrides the content of a link, i.e. only the aria-label value is announced, while the link content is ignored. In the current implementation, when the link opens normally, there's no need to override the link content. Not saying the current solution is ideal 🙂 Honestly, I'd rather use a screen-reader-text appended to the link content.

[ellatrix]

@afercia Cool thanks for the quick reply, that makes sense then.

[ryanwelcher]

@afercia @iseulde I agree that the current implementation is not ideal. I was not able to figure out how to inject a span tag with the screen-reader-text class using the current API.

[oandregal]

Works as expected.

[ellatrix]

Thanks @nosolosw!