Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1197 #1238

Closed
wants to merge 1 commit into from
Closed

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jun 18, 2017

Fix "excerpt" word typo on components/dashicon/index.js
Fixes #1197

Fix "excerpt" word typo on components/dashicon/index.js
@BE-Webdesign
Copy link
Contributor

Hi @iamgabrielma,

Thank you for the fix!! I think this needs to be done in the dashicon repository as well. The file that is edited is being generated from there. I think all you need to do is change the filename svg/exerpt-view.svg to svg/excerpt-view.svg. Once that change is made we can merge, so that we know the two will be consistent.

iamgabrielma added a commit to iamgabrielma/dashicons that referenced this pull request Jun 18, 2017
@iamgabrielma
Copy link
Contributor Author

Thanks @BE-Webdesign , that definitely makes sense. I think should be alright now

@jasmussen
Copy link
Contributor

Closing this one because there's an upstream PR now! Thanks @iamgabrielma

WordPress/dashicons#200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants