Inline Link: Set link text to post title when post selected from dropdown

[ebinnion]

Fixes #11930

Description

In #11930, it was requested that the link selector insert the post title as the link text instead of the link href as the link text.

This PR will ensure that when creating a new link, after searching for and selecting a post, that new link does use the post title. Updating a link does not change the link's text.

Design consideration: When updating an existing link by searching for a post, should the link text become the post title of the post? For example, let's say I search for "Same Page" and insert a link to that page. The link text would be "Sample Page". Now, let's say I edit that link, search for "Hello World!" and select the "Hello World!" post. Should the link text now be "Hello World!"?

How has this been tested?

I am on Mac and Chrome 70.0.3538.110 (Official Build) (64-bit). I tested by:

• Inserting https://facebook.com into the new link UI
• Searching for "Sample Page" and inserting a link via the new link UI
• Updating an existing link and searching for the "Hello World!" post
• Updating an existing link and setting it to https://facebook.com

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[jameslesliemiller]

Is the link tool aware of whether the existing link is a link to a post?

If it is — and can compare the existing link text to the post title — then it makes sense to update the link text to the new post title where existing link text equals the post title.

If it is not aware, or is but cannot perform a comparison of the existing link text to the post title of the linked post, then it should not update the link text upon updating the href value. Otherwise, it may lead to overwriting descriptive link text or other undesirable changes.

[mapk]

I agree with @jameslesliemiller here. If it's a clear swap of one post & post title link with another, great. Otherwise refrain from it so we don't overwrite custom text the user may have intended to keep.

[adnan-cefalo]

@talldan, @ellatrix, Can you review it and remove the block?

[youknowriad]

Hi There! I've triaging PRs today and it seems this one is stale and has some potential blockers to implement it. I'm going to close now but please consider reopening if these issues are solved. Thanks for your efforts.