Add inspector controls #1278
Add inspector controls #1278
Conversation
|
There are some failing tests here due to missing https://travis-ci.org/WordPress/gutenberg/jobs/244678746 As a quality-of-life tip, when rebasing, you needn't create a separate pull request, but rather can force push atop your existing branch (e.g. |
|
|
||
| return ( | ||
| <BaseControl label={ heading } id={ id }> | ||
| <label className="blocks-checkbox-control__label" htmlFor={ id }> |
There was a problem hiding this comment.
Missed this before. We shouldn't combine approaches of implicit and explicit labelling, between htmlFor and nesting input as a child of the label. From previous conversations with @afercia , htmlFor should be our preferred approach as it is better supported by screen readers.
|
This looks good to me 👍 |
| * WordPress dependencies | ||
| */ | ||
| import { withInstanceId } from 'components'; | ||
| import Toggle from 'components/form-toggle'; |
There was a problem hiding this comment.
Minor: We should import from the top-level, i.e. import { withInstanceId, Toggle } from 'components';
| * WordPress dependencies | ||
| */ | ||
| import { withInstanceId } from 'components'; | ||
| import { isEmpty } from 'lodash'; |
There was a problem hiding this comment.
lodash is an external dependency, not a WordPress dependency.
| * WordPress dependencies | ||
| */ | ||
| import { withInstanceId } from 'components'; | ||
| import { isEmpty } from 'lodash'; |
There was a problem hiding this comment.
Same note about Lodash from previous.
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { withInstanceId, Toggle } from 'components'; |
There was a problem hiding this comment.
Oof, while this is preferred, we're also not currently exporting Toggle from components/index.js as we should be. Causes an error when selecting the text block.
youknowriad
force-pushed
the
add/inspector-controls-2
branch
from
63e88cd
to
452c4a5
Compare
|
I took the liberty to update this to fix the ToggleControl issue. I'm going to merge this to unblock #1191 Thanks awesome work here. |
This is a rebased version of #1202 whilst also including #1198.