Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 12033 url label #12959

Merged
merged 37 commits into from
Feb 13, 2019
Merged

Conversation

timwright12
Copy link
Contributor

Description

Fixes #12033

How has this been tested?

Browser
Local Unit
Local e2e

Screenshots

screen shot 2018-12-17 at 3 52 18 pm

Types of changes

Bug fix/suggestion to update the permalink label to be more descriptive

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Tim Wright added 28 commits October 30, 2018 16:28
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @timwright12. The label change seems to be working and now we see "URL Slug" as shown in your screen shot. I fear some users may not know what "slug" means but I don't have a better idea.
cc: @jasmussen, @karmatosed as they may be able to provide some ideas.

@@ -11359,7 +11359,7 @@
},
"yargs": {
"version": "11.1.0",
"resolved": "http://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz",
"resolved": "https://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this URL changes may be unintentional? If they are intentional maybe we can do the update to https in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgefilipecosta I think that just happened on the npm install, but I can manually revert it if it's a concern

@jasmussen
Copy link
Contributor

I agree "slug" isn't the best word. "Link title (URL slug)" might work better?

@gziolo gziolo added the [Type] Enhancement A suggestion for improvement. label Feb 7, 2019
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

screenshot 2019-02-12 at 11 08 45

Thanks for this.

I'd appreciate final eyes by @talldan or others, but let's ship this!

@gziolo gziolo merged commit 458b945 into WordPress:master Feb 13, 2019
@timwright12 timwright12 deleted the fix/issue-12033-URL-label branch February 13, 2019 13:19
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* merge from upstream

* local save

* darked focus state outline for block lists

* sasve

* updated permalink labelling

* reverted package lock

* updated label and added helper link

* post link text update

* Update index.js
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* merge from upstream

* local save

* darked focus state outline for block lists

* sasve

* updated permalink labelling

* reverted package lock

* updated label and added helper link

* post link text update

* Update index.js
This was referenced Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar permalink panel: improve the URL field label
7 participants