Make sure RichText resigns focus when unmounted #13048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
added
the
Mobile App - i.e. Android or iOS
mzorz
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
LGTM 
Review notes in wordpress-mobile/gutenberg-mobile#423 (comment)
hypest
pushed a commit
that referenced
this pull request
Jan 2, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048)
diegoreymendez
added a commit
that referenced
this pull request
Jan 24, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048) * Implements a native version of post-title. * Removes some unnecessary log calls. * Submits a few lint fixes. * Fixes a linting issue. * When focusing the title, any focused block loses its focus. * FocusOut is now wired for post-title for mobile. * Removes unused some code. * Added a file I failed to commit. * Fixes a linting issue.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048)
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048) * Implements a native version of post-title. * Removes some unnecessary log calls. * Submits a few lint fixes. * Fixes a linting issue. * When focusing the title, any focused block loses its focus. * FocusOut is now wired for post-title for mobile. * Removes unused some code. * Added a file I failed to commit. * Fixes a linting issue.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048)
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* temporarily disable link formatting * Make sure RichText resigns focus when unmounted (#13048) * Implements a native version of post-title. * Removes some unnecessary log calls. * Submits a few lint fixes. * Fixes a linting issue. * When focusing the title, any focused block loses its focus. * FocusOut is now wired for post-title for mobile. * Removes unused some code. * Added a file I failed to commit. * Fixes a linting issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where TextInputState would still believe a specific RichText instance was focused after it was removed from view, so selecting any non-text block (e.g. image) would try to blur a RichText that didn't exist anymore and crash.
This will check if RichText is focused and unfocus when the component is unmounted
To fix wordpress-mobile/gutenberg-mobile#415
Relevant PR at wordpress-mobile/gutenberg-mobile#423