eslint-plugin: Enforce object-shorthand #13400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
approved these changes
Jan 22, 2019
|
Discussed in #core-js weekly meeting (link requires registration) https://wordpress.slack.com/archives/C5UNMSU4R/p1548167064197400 Per discussion, I updated the |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Packages: Use object shorthand notation when possible * eslint-plugin: Enforce object-shorthand * Docs: Remove coding guidelines merged upstream to WP standard * Docs: Add object shorthand style to coding guidelines
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Packages: Use object shorthand notation when possible * eslint-plugin: Enforce object-shorthand * Docs: Remove coding guidelines merged upstream to WP standard * Docs: Add object shorthand style to coding guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to propose adding
object-shorthandas an enforced rule in the ESLint default configurations. This shorthand is conventionally used in most places, though by the omission of the rule, some inconsistencies have surfaced. The rule provides a "fixable" implementation, used here to correct the inconsistencies.Pending Considerations:
This addition should be made in conjunction with a discussion in Core JS weekly chat about introduction of new rules, particularly with regard to:
Testing instructions:
There should be no lint errors: