Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_load_list_reusable_blocks #13456

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 23, 2019

Related: #11015

This pull request seeks to deprecate gutenberg_load_list_reusable_blocks. The enqueuing of these scripts is already handled in core.

See:

Gutenberg still overrides the script with its own variant, should their be any future changes to this script handle.

Testing Instructions:

Verify the Import from JSON / Export to JSON functionality on the reusable blocks list screen is still functional. This can be found under More > Manage All Reusable Blocks from the block editor.

@aduth aduth added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jan 23, 2019
@aduth aduth added Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code and removed Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jan 23, 2019
@aduth aduth force-pushed the remove/gutenberg_load_list_reusable_blocks branch from b97d974 to db3592d Compare January 25, 2019 21:34
@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 25, 2019
@aduth aduth merged commit 6544035 into master Jan 26, 2019
@aduth aduth deleted the remove/gutenberg_load_list_reusable_blocks branch January 26, 2019 04:53
daniloercoli added a commit that referenced this pull request Jan 26, 2019
…rnmobile/372-enter-key-detection-to-title

* 'master' of https://github.com/WordPress/gutenberg: (29 commits)
  Update for RangeControl documentation (#12564)
  Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456)
  Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488)
  Replace the fullscreen "exit" icon with a back arrow (#13403)
  Include :visited links in button color (#12183)
  Amazon Kindle block (#13510)
  Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457)
  Add watcher on Linux: change fs to node-watch (#13448)
  Plugin: Deprecate `gutenberg` theme support (#13458)
  Datepicker: Add inValidDay support (#12962)
  Block Switcher: Render disabled button even if multi-selection (#13431)
  Plugin: Deprecate gutenberg_register_post_types (#13468)
  Plugin: Deprecate register_tinymce_scripts (#13466)
  Set minimum of words for RSS excerpt (#13502)
  Plugin: Deprecate gutenberg_get_block_categories (#13454)
  Plugin: Deprecate gutenberg_content_block_version (#13469)
  API Fetch: Expose nonce on created middleware function (#13451)
  Plugin: Remove list screens integrations (#13459)
  Plugin: Remove core-defined block detection functions (#13467)
  Spec Parser: Move generated spec parser to package (#13493)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants