Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand block template examples #13494

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Expand block template examples #13494

merged 2 commits into from
Jan 28, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jan 24, 2019

Description

Adds examples for PHP and JS for using templates.

Fixes #8251

How has this been tested?

Implement examples and confirm they work as explained.

See documentation view on branch

Types of changes

Documentation.

Adds examples for PHP and JS for using templates.

Fixes #8251
@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Jan 24, 2019
@mkaz mkaz self-assigned this Jan 24, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In overall looks good, it needs some consolidation and should be ready to go.

@gziolo
Copy link
Member

gziolo commented Jan 25, 2019

@jorgefilipecosta can you double check JS example for InnerBlocks and template prop?

Update function names to be consistent across example.
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the update. I would appreciate some confirmation from someone familiar with InnerBlocks and templates but this shouldn't be a blocker.

@mkaz mkaz merged commit b944ed7 into master Jan 28, 2019
@youknowriad youknowriad added this to the Documentation & Handbook milestone Jan 28, 2019
@youknowriad youknowriad deleted the docs/8251/templates branch January 28, 2019 19:59
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Expand block template examples

Adds examples for PHP and JS for using templates.

Fixes #8251

* Consolidate examples and cleanup

Update function names to be consistent across example.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Expand block template examples

Adds examples for PHP and JS for using templates.

Fixes #8251

* Consolidate examples and cleanup

Update function names to be consistent across example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants