RSS block: excerpt length label #13501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
added
[Type] Copy
Soean
changed the title
gziolo
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
Code 👍
I hope we get also copy confirmation from someone who previously worked on PRs with copy updates:
@michelleweber, @samikeijonen or @dimadin?
We are also seeking for help with reviewing all translations added to the new RSS block.
gziolo
added
the
Needs Copy Review
|
Looks good! |
|
Thanks, @michelleweber for very quick feedback, much appreciated 🙇 |
|
+1 from me. |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the label of max word length setting in the RSS block.
From
Max length of the excerpttoMax number of words in excerptBefore:
After:
Part of this issue collection: #13498