WIP: make shift+enter work in lists

[ellatrix]

Description

Fixes #11215.

How has this been tested?

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[youknowriad]

It seems like indent/outdent buttons are not working properly when I have new lines in list items?

[ellatrix]

@youknowriad Hm, seems to work for me. Maybe it's gone after the rebase? If not, could you provide exact steps?

[youknowriad]

nothing special just use this

<!-- wp:list -->
<ul><li>test<br>sdf<br>sdf</li><li>test</li><li>test</li></ul>
<!-- /wp:list -->

put the caret in the second list item and click the "indent" button.

[youknowriad]

Oh sorry! you're right, it's gone after the rebase.

[youknowriad]

I think, now that we have this PR. We should update the transform from the paragraph to list to avoid creating multiple list items if we have <br> elements in the paragraph block.

[ellatrix]

@youknowriad If I remember correctly that logic was added by intention. I believe someone asked specifically to have it like this, and I kind of agree that it makes sense. Cc @mcsf.

[youknowriad]

Right now if you select three paragraphs, each one with three lines (<br>), and convert them to a list it creates a list with 9 items instead of 3, it doesn't feel right to me personally.

[ellatrix]

@youknowriad Yeah that's true. I think we shouldn't convert on line breaks if multiple paragraphs are selected. If only one is selected, we can create list items from every line. How does that sound?

[youknowriad]

I prefer consistency but it's better yes

[youknowriad]

LGTM 👍 Maybe a small e2e test?

[ellatrix]

Yes, just added it :)

[mcsf]

Yeah that's true. I think we shouldn't convert on line breaks if multiple paragraphs are selected. If only one is selected, we can create list items from every line. How does that sound?

Sounds good to me, @iseulde.

[ellatrix]

@mcsf Already merged in #13832. :)