Fix: Hide empty categories in categories block. #13549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
youknowriad
added
the
Good First Review
Soean
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Backend (JS):
Frontend (PHP):
In the PHP code, the parent categories also sum up the count of the child categories. Maybe we can solve this with a server side rendered block?
Empty child categories are hidden, the structure is now the same in the frontend and backend, so I think this PR is fine.
jorgefilipecosta
deleted the
fix/hide-empty-cagories-in-categories-block
branch
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This commit uses hide_empty option during categories request to make sure categories that have no posts are not displayed in the categories block edit view. On the frontend, they are not rendered so the edit view should replicate that. Some categories may still show zero as a count. That happens because these categories have descendant categories with posts associated to them.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This commit uses hide_empty option during categories request to make sure categories that have no posts are not displayed in the categories block edit view. On the frontend, they are not rendered so the edit view should replicate that. Some categories may still show zero as a count. That happens because these categories have descendant categories with posts associated to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13440
This PR uses hide_empty option during categories request to make sure categories that have no posts are not displayed in the categories block edit view. On the frontend, they are not rendered so the edit view should replicate that.
Some categories may still show zero as a count. That happens because these categories have descendant categories with posts associated to them.
How has this been tested?
Add the categories block.
Enable the show post count option.
Verify categories with no posts associated to them or one of their descendants don't appear in the edit view.