Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for failed upload retry #13601

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Support for failed upload retry #13601

merged 3 commits into from
Jan 30, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Jan 30, 2019

IN PROGRESS - NOT READY FOR REVIEW

Description

This adds the retry interface for failed uploads in mobile Gutenberg

@mzorz mzorz added Mobile Web Viewport sizes for mobile and tablet devices Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jan 30, 2019
@mzorz mzorz requested a review from marecar3 January 30, 2019 15:09
marecar3
marecar3 approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marecar3 marecar3 merged commit b577d29 into rnmobile/upload_media_failed_state Jan 30, 2019
@mzorz mzorz mentioned this pull request Jan 31, 2019
Merged
1 task
@mzorz mzorz deleted the rnmobile/retry-failed-upload branch January 31, 2019 03:15
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzorz @marecar3 @gziolo