Blocks: Add a delete button #1367
Conversation
youknowriad
added
the
[Type] Bug
youknowriad
added
[Feature] Blocks
editor/block-right-menu/index.js
Outdated
| className="editor-block-right-menu__control" | ||
| onClick={ onDelete } | ||
| icon="trash" | ||
| label={ __( 'Delete the block' ) } |
There was a problem hiding this comment.
I'm sure we'll need some aria roles here that say which block you are deleting :)
There was a problem hiding this comment.
We use the position for the block mover. I can do the same Delete the block at the position %d but I'm not sure it's relevant since the mover is about swapping positions.
There was a problem hiding this comment.
Delete %s block with the string being the block name maybe?
editor/block-right-menu/index.js
Outdated
| */ | ||
| import './style.scss'; | ||
|
|
||
| function BlockRightMenu( { onDelete } ) { |
There was a problem hiding this comment.
Can we find a more meaningful name for this one?
There was a problem hiding this comment.
For context, it'll contain a delete and a cog button. Not sure how to name it
There was a problem hiding this comment.
Ok going for that.
|
I'd like to polish the icon a bit. And perhaps have a smaller version (mockups use 18px gridicons). But that's a separate task. Nice, looks good 👍 |
|
@jasmussen yep, feel free to update the PR if you want to before or after merge :) |
|
I think this is a post merge thing ;) Thanks. |
youknowriad
force-pushed
the
add/block-delete-button
branch
from
5d737e9
to
e429998
Compare
|
Let's 🚢 |
closes #130