Switch a bunch of documentation titles to title case #13714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
oandregal and
youknowriad
as code owners
danielbachhuber
added
[Type] Bug
|
I honestly don't know what should be the preferred style. Randomly looking through other documentation I see both, just one example here: |
gziolo
approved these changes
Feb 7, 2019
|
@gziolo Any ideas on why the build is failing with this?
|
Nevermind, I've found the issue. |
|
@danielbachhuber The docs manifest needs to be updated; it contains the doc titles which are extracted from the markdown. |
Yep, done in 8c5220b |
chrisvanpatten
approved these changes
Feb 7, 2019
docs/designers-developers/developers/tutorials/javascript/scope-your-code.md
Outdated
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/javascript/versions-and-building.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: danielbachhuber <daniel@bachhuber.co>
Co-Authored-By: danielbachhuber <daniel@bachhuber.co>
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Switch a bunch of documentation titles to title case * Fix one lingering instance * Update `manifest.json` with new titles * Fix merge conflict discrepancy * npm should always be lowercase Co-Authored-By: danielbachhuber <daniel@bachhuber.co> * Correct spelling for JavaScript Co-Authored-By: danielbachhuber <daniel@bachhuber.co> * Update `manifest.json` again
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Switch a bunch of documentation titles to title case * Fix one lingering instance * Update `manifest.json` with new titles * Fix merge conflict discrepancy * npm should always be lowercase Co-Authored-By: danielbachhuber <daniel@bachhuber.co> * Correct spelling for JavaScript Co-Authored-By: danielbachhuber <daniel@bachhuber.co> * Update `manifest.json` again
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.