Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text displayed when an embed can't be previewed #13715

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Update text displayed when an embed can't be previewed #13715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2fd1e4
Update text displayed when an embed can't be previewed
brentswisher Feb 7, 2019
f55c7b8
Add translator note for update to embedded content np preview message
brentswisher Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-library/src/embed/embed-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ class EmbedPreview extends Component {
{ ( cannotPreview ) ? (
<Placeholder icon={ <BlockIcon icon={ icon } showColors /> } label={ label }>
<p className="components-placeholder__error"><a href={ url }>{ url }</a></p>
<p className="components-placeholder__error">{ __( 'Sorry, this embedded content cannot be previewed in the editor.' ) }</p>
<p className="components-placeholder__error">
{
/* translators: %s: host providing embed content e.g: www.youtube.com */
sprintf( __( "Embedded content from %s can't be previewed in the editor." ), parsedHostBaseUrl )
}
</p>
</Placeholder>
) : embedWrapper }
{ ( ! RichText.isEmpty( caption ) || isSelected ) && (
Expand Down