Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: Show background and increased opacity on disabled switcher #13721

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Try: Show background and increased opacity on disabled switcher #13721

merged 2 commits into from
Feb 12, 2019

Commits on Feb 7, 2019

  1. Try: Show background and increased opacity on disabled switcher 

    This one goes out to all the @chrivanpatten's in the crowd!

Well, specifically, it is in response to this conversation we had here: #11669 (comment)

The problem: we always show the Block Switcher interface, even if no transformations are available. When no transformations are available, the buttonis _disabled_, which usually means it needs to have very contrast.

However in this case, the block switcher also works as a block type indicator, which makes it valuable to be able to see the icon in question.

This PR tries to marry the two challenges and shows the button as disabled adding a light gray background, but still increasing the opacity.

Thoughts?
    Joen Asmussen committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    2fc5404 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Try darker gray and monochrome icon.

    Joen Asmussen committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    826ab85 View commit details
    Browse the repository at this point in the history