[Mobile] UI for size image settings #13728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
etoledom
requested review from
gziolo,
noisysocks,
oandregal,
talldan and
youknowriad
as code owners
etoledom
removed request for
youknowriad,
oandregal,
noisysocks,
talldan and
gziolo
gziolo
reviewed
Feb 7, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Mobile: Importing SelectControl as native picker for iOS and Android * Adding iOS version of SelectControl as UIActionSheet. * Mobile: select-cell name change * Adding Android selector control based on modal. * Fix lint issues * Fix lint issues * Updated Android selector to show as BottomSheet * Moving SelectControl to components/mobile as `Picker` * Fix lint issues * Remove mobile `modal` component import * Updated SelectCell to PickerCell * Fix lint issues * Renaming styles.scss to styles.native.scss
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Mobile: Importing SelectControl as native picker for iOS and Android * Adding iOS version of SelectControl as UIActionSheet. * Mobile: select-cell name change * Adding Android selector control based on modal. * Fix lint issues * Fix lint issues * Updated Android selector to show as BottomSheet * Moving SelectControl to components/mobile as `Picker` * Fix lint issues * Remove mobile `modal` component import * Updated SelectCell to PickerCell * Fix lint issues * Renaming styles.scss to styles.native.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a mobile picker component, and a PickerCell that uses it.
The Picker can be used stand alone too.
This picker will show the native ActionSheet on iOS and our custom BottomSheet on Android, as requested by Thomas.
This PR manages just the UI, so the size image settings are not updated after the selection.
To test:
gutenberg-mobilebranch and run the app.Image Size.