Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Remove size settings #13750

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Mobile: Remove size settings #13750

merged 4 commits into from
Feb 11, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 7, 2019 •
edited
Loading

Description

This is a small PR to remove the option to edit sizes in Image Blocks.

I also took the opportunity to organize import statements in image/edit.native.js.

screen shot 2019-02-07 at 9 58 20 pm

To test:

  • Check out the related gutenberg-mobile branch and run the app.
  • Add an image block and add an image to it.
  • Open the image settings.
  • Check that the Image Size option is not there.

@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 7, 2019
@etoledom etoledom self-assigned this Feb 7, 2019
@etoledom etoledom requested a review from pinarol February 7, 2019 20:59
This was referenced Feb 7, 2019
Merged
Merged
Closed
pinarol
pinarol approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@etoledom
Copy link
Contributor Author

Thank you!

@etoledom etoledom merged commit 1c583b2 into master Feb 11, 2019
@etoledom etoledom deleted the rnmobile/remove-size-settings branch February 11, 2019 16:19
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@etoledom @youknowriad
Mobile: Remove size settings (#13750)
d623188 
* Mobile: Remove Size Setting from Image Block.

* Organizing imports on mobile ImageEdit

* Fix lint issues
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@etoledom @youknowriad
Mobile: Remove size settings (#13750)
1759e0b 
* Mobile: Remove Size Setting from Image Block.

* Organizing imports on mobile ImageEdit

* Fix lint issues
@designsimply designsimply mentioned this pull request Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@etoledom etoledom

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @pinarol