Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call onInput in onCompositionEnd #13807

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Call onInput in onCompositionEnd #13807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/editor/src/components/rich-text/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export class RichText extends Component {
// (CJK), do not trigger a change if characters are being composed.
// Browsers setting `isComposing` to `true` will usually emit a final
// `input` event when the characters are composed.
if ( event.nativeEvent.isComposing ) {
if ( event && event.nativeEvent.isComposing ) {
return;
}

Expand Down Expand Up @@ -385,7 +385,7 @@ export class RichText extends Component {
onCompositionEnd() {
// Ensure the value is up-to-date for browsers that don't emit a final
// input event after composition.
this.onChange( this.createRecord() );
this.onInput();
}

/**
Expand Down