Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: mention browserslist usage via browserslistrc file #13810

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Docs: mention browserslist usage via browserslistrc file #13810

merged 1 commit into from
Feb 13, 2019

Conversation

simison
Copy link
Member

@simison simison commented Feb 11, 2019

Mention browserslist usage via .browserslistrc file in shareable browserslist-config package.

See docs https://github.com/browserslist/browserslist#readme

@@ -20,6 +20,12 @@ Add this to your `package.json` file:
]
```

Alternatively, add this to `.browserslistrc` file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They mention also browserslist file in docs https://github.com/browserslist/browserslist#config-file:

Browserslist config should be named .browserslistrc or browserslist and have browsers queries split by a new line. Comments starts with # symbol:...

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I haven't tested but I trust the docs :)

@gziolo gziolo added the [Type] Build Tooling Issues or PRs related to build tooling label Feb 11, 2019
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Feb 11, 2019
@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Feb 11, 2019
@gziolo gziolo removed this from the 5.1 (Gutenberg) milestone Feb 11, 2019
@simison
Copy link
Member Author

simison commented Feb 11, 2019

I haven't tested

😅 It better work:

extends @wordpress/browserslist-config

@gziolo gziolo merged commit ca2d424 into WordPress:master Feb 13, 2019
@simison simison deleted the patch-1 branch February 13, 2019 06:26
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants