Quote Block: Remove left padding from quote block when its centred #13846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
gziolo
added
[Type] Bug
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This was referenced Apr 30, 2020
This was referenced May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the
padding-lefthas been removed from the quote block when it's aligned centre.Fixes #13845.
How has this been tested?
This has been tested on my localhost set up (Laravel Valet) in Firefox 65.0, Mac OSX 10.14.
I've tested this change with Twenties Nineteen down to Twenty Fifteen; Twenties Seventeen, Sixteen and Fifteen all remove the left and right padding from this block, so this issue wasn't present in those themes (nor did this update change anything in them).
When testing Twenty Nineteen, I tested the theme using the patch from https://core.trac.wordpress.org/ticket/46239. This patch fixes some visual issues in the theme, to get it lined up with changes made in #13248.
Screenshots
Before update:
After update:
Types of changes
Bug fix (non-breaking change which fixes an issue) - strictly CSS, adding a
padding-left: 0for when the text is aligned centre in the quote block.Checklist: