Remove the limit of 3 keywords for the block registration

[gziolo]

Description

Opened to rebase and close #11953. All work was done by @jameelmoses.

Fixes: #11949
Instead of failing to register a block if more than 3 keywords are given, only return the first 3 by slicing the keywords array.

How has this been tested?

npm run lint

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[gziolo]

#11953 was ✅ by @aduth and myself. Merging based on that.

[hacknug]

@gziolo why was this undocumented when it's still something that applies? Docs should be clear about it, no?

Also, why the hard limit? Couldn't find anything about the reasoning behind this limitation. Asking just for curiosity, not sure I'd ever need more than three keywords when I can have more than one in each string.

[gziolo]

There is no limit anymore.

[hacknug]

But only the first three keywords are used when searching for a block. Am I missing something?

[gziolo]

But only the first three keywords are used when searching for a block. Am I missing something?

Can you reproduce it?

Looking at code, I can't find any logic which would ignore any keywords:

gutenberg/packages/block-editor/src/store/selectors.js

Line 1193 in fd7f27b

keywords: blockType.keywords,

gutenberg/packages/block-editor/src/components/inserter/menu.js

Line 71 in fd7f27b

return matchSearch( item.title ) || some( item.keywords, matchSearch ) || ( itemCategory && matchSearch( itemCategory.title ) );

[hacknug]

You're right. I've just tested with a couple blocks I built from scratch and it definitely shows up. Issue was with ACF blocks so it might be something on their side. I'll look into it and follow up there. Sorry for the trouble ❤️

[gziolo]

You're right. I've just tested with a couple blocks I built from scratch and it definitely shows up. Issue was with ACF blocks so it might be something on their side. I'll look into it and follow up there. Sorry for the trouble ❤️

It's totally fine. Thank you for testing with custom blocks 👍