Mobile Block Placeholder fixes #13945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
changed the title
gziolo
added
the
Mobile App - i.e. Android or iOS
etoledom
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Looks good!
Tested via: wordpress-mobile/gutenberg-mobile#616 (review)
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Use correct font and padding for block placeholder. * Match text for placeholder for paragraph to block placeholder. * Make placeholder text simpler. * Make min height smaller to make component entered. * Fix default placeholder color. * Use variable for color. * Change minimum height of text blocks. * Remove top padding on the appender.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Use correct font and padding for block placeholder. * Match text for placeholder for paragraph to block placeholder. * Make placeholder text simpler. * Make min height smaller to make component entered. * Fix default placeholder color. * Use variable for color. * Change minimum height of text blocks. * Remove top padding on the appender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix alignment issues between the block placeholder and paragraph placeholder and make the text the same for both.
How has this been tested?
It can be tested on the gb-mobile repo using this PR: wordpress-mobile/gutenberg-mobile#616