-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: update CheckboxControl readme #14153
Conversation
These changes add design documentation.
Sorry about all of the requested reviews. I didn't do that so it must be an automated thing? |
The images do not have alt description because if the images were removed, the content would not lose any value (except for maybe the first image?). ref:(#11226 (comment)) A11y feedback on this would be great. |
It's part of the code owners workflow implemented in the project. All those assigned had volunteered themselves to be assigned. See also: |
@karmatosed This PR does not have a design or a11y review, but I think it should be good to merge once an owner approves. |
@drw158 I agree and I will now approve. We can (and should) iterate, but it's important to get these in. |
* Initial commit to update CheckboxControl readme These changes add design documentation. * Fix tabbing on code example
* Initial commit to update CheckboxControl readme These changes add design documentation. * Fix tabbing on code example
Description
This PR adds design guideline documentation in addition to the development documentation that existed previously. These guidelines are 'best practices' for the usage of the component, as well as describing the component in more detail.
Screenshots
A preview can be seen here, although it doesn't represent what it will look like in the handbook:
preview
Feedback
I'd appreciate feedback on:
Thank you!