Implement lists for ReactNative #14249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RichText: only ignore input types that insert HTML * Mark RichTextInputEvent as unstable * Use Set
…eters returned onChange, and we forgot to update the PostTitle component (#13967)
Upload media progress bar is missing while media is uploading new
* Trigger onFocusStatusChange from PostTitle * Fix lint issue * Update post title shadow mechanism Also open inner ref so that focus state can be updated when focus is made programmatically * Update props * Update onRef as ref * Update title padding&margin
* Changed upload media icon color * Changed media placeholder background color
* Fix unexpected token in native code * Dummy commit to trigger Travis * Include the rnmobile release branch to Travis builds
* Mobile: Replaced Links UI with bottom-sheet component * Mobile links UI: Removed commented code. * Mobile: Fix lint issues * Mobile Links UI: Remove autofocus on Android. This hides an issue where the modal sometimes will be under the keyboard on Android.
* Remove title vertical paddings for Android * Revert "Remove title vertical paddings for Android" This reverts commit 09f0d35. * Import padding variables
* Make richText height changes contained to the rich text block. * Remove commented out code. * Remove aztec height from state. * Allow minHeight to be optional. * Remove minHeight from postTitle. * Remove minHeight on heading block.
SergioEstevao
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
dmsnell,
jorgefilipecosta,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
oandregal,
notnownikki,
ntwb,
Soean and
swissspidy
as code owners
|
Closing this in favour of: #14636 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the list block by only changing components and not touching the code of the block ( no need to create a native version).
This achieved by improving the implementation of the block-edit context in RNMobile in order to send the isSelected and onFocus props to the RichText components.
For the moment it doesn't implement the indent and outdent buttons, but those should be relatively after a better understanding of the format and selection code behind it.
At the moment the block allows the breaking of the list by tapping two enters in a row on an empty list element. This can be solved by changing Aztec to send the event up instead of breaking the list by itself.
How has this been tested?
This can be tested using this PR on gb-mobile: wordpress-mobile/gutenberg-mobile#704