Refactor resetBlocks to action-generators #14594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
requested review from
gziolo,
noisysocks,
talldan,
youknowriad,
ajitbohra,
chrisvanpatten,
mkaz,
oandregal and
notnownikki
as code owners
|
I'm doing this in smaller pulls so it's easier to review |
nerrad
force-pushed
the
refactor/convert-block-effects-to-controls
branch
from
a240b2a
to
448f939
Compare
|
This will need a refresh after #14003 which, as noted at #14003 (comment) , had some overlapping effort with respect to the |
nerrad
force-pushed
the
refactor/convert-block-effects-to-controls
branch
from
448f939
to
994d5a6
Compare
nerrad
changed the title
|
Latest work refreshes this pull to refactor Unit tests pass, awaiting results of e2e tests via travis. |
|
Size Change: -12 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
|
This pull is ready for another review. |
8 tasks
|
If @adamziel's pull is more recent and refactors the same thing, probably best to focus on his. This pr is really stale as it's been sitting for a while. |
|
Yes, it is. Let's focus on the most recent one. Thank you for understanding 😃 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the ongoing refactor of effects to controls/action-generators, this is the first part of doing the work in the
@wordpress/block-editorpackage. In this pull:replaceBlocksis migrated to action-generators.STORE_KEYconstant introduced and exported (this reduces chance of human error in adding the store reference). Importing the key allows for automatic dependency management to pick up theblock-editorpackage dependency as well.controls.jsfile and usage since@wordpress/data-controlsis a suitable replacement.How has this been tested?
Types of changes
This should not be a breaking change.
Checklist: