Annotations & Performance: remove use of Memize #14664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Rich Text
ellatrix
requested review from
aduth,
atimmer,
jorgefilipecosta and
youknowriad
as code owners
ellatrix
force-pushed
the
try/annotations-remove-memize
branch
2 times, most recently
from
f4c6ffb
to
7399888
Compare
ellatrix
commented
Mar 28, 2019
| @@ -25,6 +25,7 @@ | |||
| "@wordpress/compose": "file:../compose", | |||
| "@wordpress/data": "file:../data", | |||
| "@wordpress/escape-html": "file:../escape-html", | |||
| "@wordpress/hooks": "file:../hooks", | |||
There was a problem hiding this comment.
I saw this dependency was missing.
ellatrix
added
[Type] Code Quality
5 tasks
atimmer
approved these changes
Apr 3, 2019
ellatrix
force-pushed
the
try/annotations-remove-memize
branch
from
382baa8
to
e457a8b
Compare
|
Thanks @atimmer for the review! |
aduth
reviewed
Apr 3, 2019
| @@ -27,7 +27,6 @@ | |||
| "@wordpress/i18n": "file:../i18n", | |||
| "@wordpress/rich-text": "file:../rich-text", | |||
| "lodash": "^4.17.11", | |||
| "memize": "^1.0.5", | |||
There was a problem hiding this comment.
package-lock.json should have been updated as a result of this change. There's local revisions after running npm install in master.
Aside: Travis should be catching this, and it's unclear why it's not.
This was referenced Apr 15, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split out from #14641.
Some functions were memoized in #12161, because new array and objects are returned as props. We can avoid this by prefixing the prop keys (as is already done in one case).
How has this been tested?
Screenshots
Types of changes
Checklist: