Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'dependencies' to 'devDependencies'. #14736

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

mchavezi
Copy link
Contributor

@mchavezi mchavezi commented Apr 1, 2019

Because it says to run npm install with --save-dev flag
"dependencies": {
"@wordpress/scripts": "3.1.0"
}

Should say:

"devDependencies": {
"@wordpress/scripts": "3.1.0"
}


## Description
<!-- Please describe what you have changed or added -->

## How has this been tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, tests ran to see how -->
<!-- your change affects other areas of the code, etc. -->

## Screenshots <!-- if applicable -->

## Types of changes
<!-- What types of changes does your code introduce?  -->
<!-- Bug fix (non-breaking change which fixes an issue) -->
<!-- New feature (non-breaking change which adds functionality) -->
<!-- Breaking change (fix or feature that would cause existing functionality to not work as expected) -->

## Checklist:
- [ ] My code is tested.
- [ ] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [ ] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [ ] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
- [ ] I've included developer documentation if appropriate. <!-- Handbook: https://wordpress.org/gutenberg/handbook/designers-developers/ -->

Because it says to run npm install with --save-dev flag
"dependencies": {
    "@wordpress/scripts": "3.1.0"
}
```
Should say:
```
"devDependencies": {
    "@wordpress/scripts": "3.1.0"
}
```
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @bigbassroller, thanks for sending your patch 👍

@nosolosw and @mkaz - was there any good reason it was recommended to install it as a regular dependency in the past? I personally would always install it as a development dependency.

@gziolo gziolo added [Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers labels Apr 1, 2019
@gziolo gziolo merged commit 0d58c70 into WordPress:master Apr 1, 2019
@oandregal
Copy link
Member

This is 👍 Checked the doc history and it always said --save-dev so having dependencies instead of devDependencies was probably a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants