Fix/post title borders in code editor #14771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Apr 2, 2019
| @@ -36,6 +36,15 @@ | |||
| // buttons to shrink anyway. | |||
| flex-shrink: 0; | |||
| } | |||
|
|
|||
| // Hide the thick block border in the Code Editor. | |||
| .edit-post-text-editor__body .editor-post-title & { | |||
There was a problem hiding this comment.
We're in the editor module, we should reference edit-post styles. If we were to override this, it should happen in the edit-post module where we use the post title component.
youknowriad
reviewed
Apr 2, 2019
| @@ -99,6 +99,16 @@ | |||
| opacity: 1; | |||
| } | |||
| } | |||
|
|
|||
| // Hide the thick block border in the Code Editor. | |||
| .edit-post-text-editor__body & { | |||
There was a problem hiding this comment.
Same as the previous comment.
There was a problem hiding this comment.
Thanks! Should be fixed in dc24fa6
youknowriad
approved these changes
Apr 3, 2019
aduth
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Remove thick left border for the title in the code editor. * Remove thick left border from the permalink field in the code editor. * Move styles into the `edit-post` module. * Remove no-longer-necessary style change. * Remove unnecessary styles.
aduth
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Remove thick left border for the title in the code editor. * Remove thick left border from the permalink field in the code editor. * Move styles into the `edit-post` module. * Remove no-longer-necessary style change. * Remove unnecessary styles.
This was referenced Apr 17, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the thick block border on the post title and permalink box, when the user is in the Code Editor. As mentioned in #14761 (review)
Before
After