Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: media text vertical align fixture and block transforms structure. #14790

Conversation

jorgefilipecosta
Copy link
Member

Description

I missed the rebasing with the master before merging #14625 which fixed media fixtures to work with the transforms tests and meanwhile a new media fixture was added.
This PR fixes the new media fixture following the same logic we applied on #14625.

How has this been tested?

I checked the automated tests pass.

@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended labels Apr 3, 2019
@gziolo gziolo added this to the 5.5 (Gutenberg) milestone Apr 3, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's all good as Travis became happy again 😃

@jorgefilipecosta jorgefilipecosta merged commit fc20eea into master Apr 3, 2019
@jorgefilipecosta jorgefilipecosta deleted the fix/media-text-vertical-align-and-transforms-test-info, branch April 3, 2019 09:12
@youknowriad youknowriad removed the [Type] Bug An existing feature does not function as intended label Apr 12, 2019
@youknowriad
Copy link
Contributor

This is not a bug right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants