Plugin: Remove PHP functions slated for 5.5. 5.4 removal #14806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Gutenberg Plugin
aduth
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
oandregal,
notnownikki and
youknowriad
as code owners
aduth
commented
Apr 3, 2019
| @@ -10,7 +10,6 @@ For features included in the Gutenberg plugin, the deprecation policy is intende | |||
| - The PHP function `gutenberg_default_post_format_template` has been removed. | |||
| - The PHP function `gutenberg_get_available_image_sizes` has been removed. | |||
| - The PHP function `gutenberg_get_autosave_newer_than_post_save` has been removed. | |||
| - The PHP function `gutenberg_default_post_format_template` has been removed. | |||
There was a problem hiding this comment.
This was duplicate. See three lines above.
youknowriad
approved these changes
Apr 4, 2019
This was referenced Apr 15, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to remove PHP functions slated for removal in the 5.5 release. It also includes deprecations which should have been — but were not — removed as of Gutenberg 5.4.
https://wordpress.org/gutenberg/handbook/designers-developers/developers/backward-compatibility/deprecations/#5-5-0
gutenberg_inithas been removed.is_gutenberg_pagehas been removed. UseWP_Screen::is_block_editorinstead.the_gutenberg_projecthas been removed.gutenberg_default_post_format_templatehas been removed.gutenberg_get_available_image_sizeshas been removed.gutenberg_get_autosave_newer_than_post_savehas been removed.gutenberg_editor_scripts_and_styleshas been removed.gutenberg_load_plugin_textdomainhas been removed.gutenberg_get_jed_locale_datahas been removed.gutenberg_load_locale_datahas been removed.Testing Instructions:
Verify there are no errors in the load or general use of the editor.
Ensure that all referenced deprecated functions are no longer present in the codebase.