Refine Bottom Sheets in/out transition #14831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As specified in wordpress-mobile/gutenberg-mobile#595 I did my best to adjust to the specs there, and for the most part the animations matches what was requested. One limitation is that due to how react-native-modal is implemented, we don't know the view's height when it's about to be presented, and so it starts the "slide in" animation not from the bottom edge, but from a lower point, since it uses the window height to displace the view and not the view's height. The result is an animation that appears slower than specified, since the view has to traverse a longer distance in the same time, and there is a delay before the view starts appearing. This is mildly annoying, but I could not find a way to make it work without rewriting react-native-modal.
koke
added
the
Mobile App - i.e. Android or iOS
etoledom
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
Looks good! Thank you @koke 🎉
I came across that same problem before, but it wasn't important at the time so I ignored it.
At some point it would be nice to solve it to be able to fully control the animations. 👍
(Unless we replace this modal for something else in the future 😛)
…/595-bottom-sheet-animation
This was referenced Apr 29, 2019
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in wordpress-mobile/gutenberg-mobile#595
I did my best to adjust to the specs there, and for the most part the animations
matches what was requested.
One limitation is that due to how react-native-modal is implemented, we don't
know the view's height when it's about to be presented, and so it starts the
"slide in" animation not from the bottom edge, but from a lower point, since it
uses the window height to displace the view and not the view's height. The
result is an animation that appears slower than specified, since the view has
to traverse a longer distance in the same time, and there is a delay before the
view starts appearing.
This is mildly annoying, but I could not find a way to make it work without
rewriting react-native-modal.
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#820