[Mobile] Fix caret position after inline paste. #14893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some consideration, I think this is ready for review. It should have minimal impact on other areas of the code, and fixes an existing issue. The other parts of the original issue (i.e. pasting multi-line content) can be addressed in another PR. |
Completely agree! 👍 |
|
Thanks @etoledom ! |
5 tasks
mchowning
pushed a commit
to mchowning/gutenberg
that referenced
this pull request
Apr 15, 2019
* Fix caret position after inline paste.
This was referenced Apr 15, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes part of this issue: wordpress-mobile/gutenberg-mobile#828 , specifically, when inline content is pasted.
How has this been tested?
This has been tested using the steps here:
wordpress-mobile/gutenberg-mobile#828 (comment)
Screenshots
Types of changes
This is a bug fix, but currently only resolves a part of the original issue. I'm leaving this as a draft PR to gather more information. It currently serves as an incremental improvement, but I'd like to have some consensus on whether it makes sense to wait for a full fix (for both inline and multi-line content) before merging.
Checklist: