Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <Button></Button> tags back into the Button readme #14964

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Add <Button></Button> tags back into the Button readme #14964

merged 1 commit into from
Apr 14, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 12, 2019

Adds <Button isDefault> and </Button> tags back into the code example in the Button readme. These were removed erroneously in #14194.

Thanks @nickylimjj for pointing this out.

@kjellr kjellr added [Type] Developer Documentation Documentation for developers [Component] Button Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Apr 12, 2019
@kjellr kjellr requested a review from davewhitley April 12, 2019 19:02
@kjellr kjellr self-assigned this Apr 12, 2019
@kjellr kjellr mentioned this pull request Apr 12, 2019
Merged
Aurorum
Aurorum approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@Aurorum Aurorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gziolo gziolo merged commit dd9bf47 into master Apr 14, 2019
@gziolo gziolo deleted the update/buton-readme branch April 14, 2019 13:34
@gziolo gziolo added this to the 5.5 (Gutenberg) milestone Apr 14, 2019
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
@kjellr @mchowning
Add <Button></Button> tags back into the Button README (WordPress#14964)
dbd60db 
These were removed erroneously in WordPress#14194.
This was referenced Apr 15, 2019
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurorum Aurorum Aurorum approved these changes

@davewhitley davewhitley davewhitley approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@kjellr kjellr

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@kjellr @davewhitley @Aurorum @gziolo