Update the version of lint-staged #14971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog:
|
mchowning
pushed a commit
to mchowning/gutenberg
that referenced
this pull request
Apr 15, 2019
## Description Fix WordPress#14784 ## How has this been tested? 1. `git add modified-files`, call the files VersionA 2. `git commit -m "some messages"`, then the program will run `npm run -s precommit` to check lint styles and some other things. 3. Encounter some errors like "Multiple spaces found", so you change the code again and save, call the files VersionB. But do not `git add` again. 4. `git commit` again, failed. Because now the `lint-staged` only check staged changes (i.e, VersionA). You should `git add` again and then `git commit` ## Screenshots <!-- if applicable --> The screenshot of running `git commit` with old version of `lint-staged`  The screenshot of running `git commit` with latest version of `lint-staged`. The blue boxes highlight the difference  ## Types of changes Upgrade lint-staged ## Checklist: - [X] My code is tested. - [X] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ --> - [X] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ --> - [X] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ --> - [X] I've included developer documentation if appropriate. <!-- Handbook: https://wordpress.org/gutenberg/handbook/designers-developers/ -->
This was referenced Apr 15, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14784
How has this been tested?
git add modified-files, call the files VersionAgit commit -m "some messages", then the program will runnpm run -s precommitto check lint styles and some other things.git addagain.git commitagain, failed. Because now thelint-stagedonly check staged changes (i.e, VersionA).You should
git addagain and thengit commitScreenshots
The screenshot of running
git commitwith old version oflint-stagedThe screenshot of running
git commitwith latest version oflint-staged. The blue boxes highlight the differenceTypes of changes
Upgrade lint-staged
Checklist: