Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Alphabetize block editor components exports #15195

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 25, 2019

Extracted from #15194

This pull request seeks to correct inconsistent alphabetization of exported entries from the packages/block-editor/src/components/index.js file.

Testing instructions:

The included changes are simply a reordering. There should be no impact on the behavior of the application. Verify that this is true.

@aduth aduth added [Type] Code Quality Issues or PRs that relate to code quality Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Apr 25, 2019
@ellatrix
Copy link
Member

Would it make sense to create a rule to force alphabetisation of all imports and exports?

@aduth
Copy link
Member Author

aduth commented Apr 26, 2019

Would it make sense to create a rule to force alphabetisation of all imports and exports?

For myself, I don't feel strongly about alphabetization for most import usage in any other file. For these "mega" files, however, I think they can serve as references where a lack of alphabetization can be more detrimental. To that end, I think a rule could help, but it would be of limited benefit, and even for how I'd done the alphabetization here, I had a hard time considering how to deal with cases where multiple exports are declared in the same statement (e.g. RichTextToolbarButton, UnstableRichTextInputEvent).

@aduth aduth merged commit db990fc into master Apr 26, 2019
@aduth aduth deleted the update/block-editor-components-alphabetize branch April 26, 2019 16:32
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants