Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y: update icon for heading block #15462

Merged
merged 1 commit into from
May 17, 2019
Merged

A11y: update icon for heading block #15462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/block-library/src/heading/icon.js
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions packages/block-library/src/heading/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { RichText } from '@wordpress/block-editor';
* Internal dependencies
*/
import edit from './edit';
import icon from './icon';
import metadata from './block.json';
import save from './save';
import transforms from './transforms';
Expand All @@ -31,7 +30,7 @@ const supports = {
export const settings = {
title: __( 'Heading' ),
description: __( 'Introduce new sections and organize content to help visitors (and search engines) understand the structure of your content.' ),
icon,
icon: 'heading',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this was done on purpose. Would be good to check the original reasons for using "T". I think it's related to i18n

Copy link
Contributor Author

@frontdevde frontdevde May 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #15340 (comment) and #15340 (comment). From what I understood in #15340 @mapk OK'd the change to H over T.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do understand the "H" is not a i18n standard for Headings, but it does match the H2, H3, and H4 heading sizes that are surfaced in the block toolbar. So there's some consistency there. Other apps like Dropbox Paper also use "H" for the heading level.

keywords: [ __( 'title' ), __( 'subtitle' ) ],
supports,
transforms,
Expand Down