Resolve block modal: make the columns have the same content space #15581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foysalremon
requested review from
ellatrix,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
youknowriad
added
the
Good First Review
talldan
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Thanks for the PR @foysalremon! It's a small change but it makes a big difference to the popover 👍
It looks like there are tests failing that are not caused by this change, I gave the tests a re-run, but they continue to fail. It might be worth rebasing/merging master into the branch, as the failing test has probably been fixed by someone else.
|
@talldan Thanks. But it seems it is failing for me on every pull request. As a newbie I don't know why. |
foysalremon
deleted the
resolve-block-make-both-column-same-content-space
branch
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose is to make both column content space same on "Resolve block" modal. Cause it is for show a visual deference to user before and after resolving block. So, line to line with same content should be accurate on view of both side to compare. This is the solve of this issue - #15235
How has this been tested?
It has been build and tested on WordPress locally by using xampp localhost
Screenshots
Before:
After
Types of changes
CSS only change on .scss
Checklist: